fix: reinitialize expired streamable sessions#2150
Open
he-yufeng wants to merge 2 commits into
Open
Conversation
🦋 Changeset detectedLatest commit: 80b3f60 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@modelcontextprotocol/client
@modelcontextprotocol/codemod
@modelcontextprotocol/server
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
Author
|
Added a patch changeset for @modelcontextprotocol/client. Local validation: pnpm exec changeset status --since upstream/main shows the client patch bump, git diff --check passed, and the pre-push hook completed typecheck, build, and lint successfully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1476.
When a Streamable HTTP server restarts, a client can keep sending POST requests with a stale
MCP-Session-Id. The SDK currently reports the server's 404 response asClientHttpNotImplementedand leaves the expired session in place.This change handles a 404 from a request that used a session ID as an expired-session signal:
Clientrun a fresh initialize handshake on the same transportThe retry is limited to one attempt so repeated 404s still surface as errors instead of looping.
To verify
pnpm --filter @modelcontextprotocol/client exec vitest run test/client/streamableHttp.test.ts -t "reinitializes and retries once"pnpm --filter @modelcontextprotocol/client exec vitest run test/client/streamableHttp.test.tspnpm --filter @modelcontextprotocol/client typecheckpnpm --filter @modelcontextprotocol/client lintgit diff --checktypecheck,build, andlint